Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add emitter to types #1200

Merged
merged 2 commits into from Mar 30, 2023
Merged

fix: add emitter to types #1200

merged 2 commits into from Mar 30, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Mar 30, 2023 •
edited

Motivation

Fixes typings

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele marked this pull request as draft March 30, 2023 06:37
@Caele Caele marked this pull request as ready for review March 30, 2023 06:40
@Caele Caele requested a review from a team March 30, 2023 06:45
@Caele Caele merged commit 2ae60c3 into master Mar 30, 2023
4 checks passed
@Caele Caele deleted the tsm/emitter-type branch March 30, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

@niekvanstaveren niekvanstaveren niekvanstaveren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Caele @veinfors @niekvanstaveren