fix(listbox): show selection toolbar when listbox opens in popover #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurwaShrivastava
changed the title
veinfors
reviewed
Mar 30, 2023
T-Wizard
reviewed
Apr 3, 2023
T-Wizard
reviewed
Apr 3, 2023
T-Wizard
reviewed
Apr 3, 2023
T-Wizard
reviewed
Apr 3, 2023
Comment on lines
+156
to
+163
| if (isPopover) { | ||
| if (!selections.isActive()) { | ||
| selections.begin('/qListObjectDef'); | ||
| selections.on('activated', show); | ||
| selections.on('deactivated', hide); | ||
| } | ||
| setShowToolbar(isPopover); | ||
| } |
There was a problem hiding this comment.
maybe also add a check if selections exists. based on that the next if does maybe it is also needed here?
T-Wizard
approved these changes
Apr 3, 2023
veinfors
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix : qlik-oss/sn-list-objects#230
Selection Toolbar will always be shown inline when the listbox opens in popover, this solves the issue with small screen as well.
With Title - small screen
Without title - small screen
Big Title Truncated - Desktop
