feat(Listbox): tap range select #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apis/nucleus/src/components/listbox/interactions/listbox-keyboard-navigation.js
T-Wizard
approved these changes
Mar 31, 2023
Yes I tested it on a iPad. I noticed that the old listbox seems to prevent gestures (like zoom) inside the listbox, so I added that as well. ffaf757 I have also tried to update the touch positions with |
T-Wizard
reviewed
Apr 3, 2023
| @@ -16,6 +23,25 @@ export default function useSelectionsInteractions({ selectionState, selections, | |||
| touchRangeSmall: false, | |||
| }); | |||
|
|
|||
| useEffect(() => { | |||
| if (!loaderRef.current?._listRef?._outerRef) { | |||
T-Wizard
reviewed
Apr 3, 2023
| listRef.removeEventListener('gesturechange', preventGestureChange); | ||
| listRef.removeEventListener('gestureend', preventGestureEnd); | ||
| }; | ||
| }, [loaderRef.current?._listRef?._outerRef]); |
There was a problem hiding this comment.
this can maybe be a problem as
loaderRef.current?._listRef?._outerRef could probably without updating the effect
if the update do not also trigger a rerender of the listbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use two finger tap to select a range on touch devices.
fixes qlik-oss/sn-list-objects#163
Single-column:
Grid-column:
Grid-row:
Requirements checklist
yarn specWhen build and tests have passed: