fix: support Enter to go from a folded listbox to a row #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanho
changed the title
johanlahti
reviewed
Apr 13, 2023
apis/nucleus/src/components/listbox/components/useTempKeyboard.js
Outdated
Show resolved
Hide resolved
T-Wizard
approved these changes
Apr 13, 2023
johanlahti
reviewed
Apr 13, 2023
| @@ -180,7 +180,7 @@ export function getListboxInlineKeyboardNavigation({ | |||
| // 3. Blur row and focus the listbox container. | |||
| keyboard.blur(); | |||
| const c = currentTarget.closest('.listbox-container'); | |||
| c.setAttribute('tabIndex', 0); | |||
| c.setAttribute('tabIndex', -1); | |||
There was a problem hiding this comment.
I think this is unnecessary, what happens if you remove it? Do we ever set it to 0 elsewhere?
There was a problem hiding this comment.
We do not set it 0 to elsewhere but to make it focusable we should set tabIndex to -1.
There was a problem hiding this comment.
I do think it needed to focus on it when keyboardNavigation is false (I think it would have no tabIndex without it)
but I am also questioning if it should be focused in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix qlik-oss/sn-list-objects#263.
The user should be able to go from a folded listbox to the first row by Enter like an unfolded listbox.
Requirements checklist
yarn specWhen build and tests have passed: