Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(listbox): keyboard navigation rendering tests #1220

Merged
merged 18 commits into from
Apr 14, 2023

Conversation

johanlahti
Copy link
Contributor

@johanlahti johanlahti commented Apr 13, 2023

Motivation

  • Break out keyboard nav tests into its own listbox-keyboard-nav.spec.js file (for performance and readability)
  • Add a scenario for keyboard navigation involving navigate rows with arrow keys, selecting, tabbing and confirming.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@johanlahti johanlahti marked this pull request as ready for review April 14, 2023 08:26
@johanlahti johanlahti merged commit 476b753 into master Apr 14, 2023
3 checks passed
@johanlahti johanlahti deleted the test/render-key-nav branch April 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants