Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix rtl for histogram and checkbox and frequency count #1221

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix: fix rtl for histogram and checkbox and frequency count #1221

merged 2 commits into from
Apr 13, 2023

Conversation

quanho
Copy link
Collaborator

@quanho quanho commented Apr 13, 2023

Motivation

To fix qlik-oss/sn-list-objects#193 and positioning of frequency count and row value when it is a number.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

T-Wizard
T-Wizard approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@T-Wizard T-Wizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also a add rtl rendering test

@quanho quanho merged commit 51b8cb1 into master Apr 13, 2023
@quanho quanho deleted the hva/sn-filterpane-193-2 branch April 13, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Wizard T-Wizard T-Wizard approved these changes

@johanlahti johanlahti Awaiting requested review from johanlahti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL histogram overlaps checkbox
2 participants
@quanho @T-Wizard