Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add right divider to listbox last column items #1222

Closed
wants to merge 3 commits into from

Conversation

cosmar26
Copy link
Contributor

@cosmar26 cosmar26 commented Apr 14, 2023

Motivation

Add a right divider to all the items of the last column.
Not adding it to all last items of each row, as in that case will be mis-aligned with the left dividers of previous items in the same column.
Resolves qlik-oss/sn-list-objects#233

Screenshot with latest fix:
Screenshot 2023-04-14 at 13 51 49

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@T-Wizard
Copy link
Collaborator

This looks odd. I expect us to want it for all items that are last in there row. not just the very last item.
(In the image that would be X,Y,Z and not just Z)

@cosmar26
Copy link
Contributor Author

cosmar26 commented Apr 14, 2023

This looks odd. I expect us to want it for all items that are last in there row. not just the very last item. (In the image that would be X,Y,Z and not just Z)

Right, will change this way. Edit: adding divider to the items of last column, see description

@cosmar26 cosmar26 changed the title fix: add right divider for last listbox item fix: add right divider to listbox last column items Apr 14, 2023
@cosmar26 cosmar26 marked this pull request as ready for review April 14, 2023 12:18
@veinfors
Copy link
Collaborator

This looks odd. I expect us to want it for all items that are last in there row. not just the very last item. (In the image that would be X,Y,Z and not just Z)

Right, will change this way. Edit: adding divider to the items of last column, see description

Can you update the image in the description to show how it looks like with that fixed as well?

@cosmar26
Copy link
Contributor Author

cosmar26 commented Apr 14, 2023

Can you update the image in the description to show how it looks like with that fixed as well?

The image in the description is updated with the latest fix (so the X is not getting the divider, just the items of last column, Y and Z)

If I add a right border also to X, will look bad as below:
Screenshot 2023-04-14 at 14 49 26

@veinfors
Copy link
Collaborator

Can you update the image in the description to show how it looks like with that fixed as well?

The image in the description is updated with the latest fix (so the X is not getting the divider, just the items of last column, Y and Z)

If I add a right border also to X, will look bad as below: Screenshot 2023-04-14 at 14 49 26

Okey... No, that doesn't look good either, I would expect it to look like this ⬆️, but being correctly aligned (the last cell should have the same width as the other cells in that column that is)

@cosmar26 cosmar26 marked this pull request as draft April 14, 2023 14:35
@cosmar26
Copy link
Contributor Author

closing as it needs further alignment with UX

@cosmar26 cosmar26 closed this May 10, 2023
@Caele Caele deleted the goa/fix-border-last-cell branch February 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small tick line missing after last grid item
4 participants