Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(listbox): add more rendering tests #1223

Merged
merged 3 commits into from Apr 20, 2023
Merged

test(listbox): add more rendering tests #1223

merged 3 commits into from Apr 20, 2023

Conversation

DanielS-Qlik
Copy link
Contributor

Motivation

Test for: RTL, grid mode without checkboxes, dense grid mode.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@DanielS-Qlik DanielS-Qlik marked this pull request as ready for review April 14, 2023 09:12
@DanielS-Qlik DanielS-Qlik merged commit 7792610 into master Apr 20, 2023
6 of 8 checks passed
@DanielS-Qlik DanielS-Qlik deleted the ild/add-rendering-tests branch April 20, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanlahti johanlahti johanlahti approved these changes

@quanho quanho Awaiting requested review from quanho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielS-Qlik @johanlahti