Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test structure nebula create #1227

Merged
merged 2 commits into from
Apr 26, 2023
Merged

test: update test structure nebula create #1227

merged 2 commits into from
Apr 26, 2023

Conversation

niekvanstaveren
Copy link
Collaborator

Motivation

Different integration test setup for template nebula charts. Changes:

  • Use playwright to start server
  • Share playwright configuration in common

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@niekvanstaveren niekvanstaveren requested review from a-m-dev and a team April 18, 2023 12:05
@Caele Caele merged commit 35bef70 into master Apr 26, 2023
3 checks passed
@Caele Caele deleted the dvr/nebula-test branch April 26, 2023 12:49
@niekvanstaveren niekvanstaveren restored the dvr/nebula-test branch May 17, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caele Caele Caele approved these changes

@a-m-dev a-m-dev Awaiting requested review from a-m-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niekvanstaveren @Caele