Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: to be able to disable systemjs in build #1230

Merged
merged 2 commits into from Apr 21, 2023

Conversation

LiKang6688
Copy link
Contributor

@LiKang6688 LiKang6688 commented Apr 19, 2023

Motivation

it takes too much time to build an extension using nebula build

solution

Add systems into config to be able to disable systemjs build

systemjs: {
    description: 'Enable to transpile a systemjs format for release',
    type: 'boolean',
    default: true,
  },

argv.systemjs && (await systemjs(buildConfig));

Usage example

qlik-oss/sn-table#991

One more thing:

Refactoring build/lib to separate related functions to its own file

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@LiKang6688 LiKang6688 marked this pull request as ready for review April 19, 2023 20:50
@LiKang6688 LiKang6688 requested a review from a team April 20, 2023 07:20
@LiKang6688 LiKang6688 merged commit 557ba46 into master Apr 21, 2023
6 of 8 checks passed
@LiKang6688 LiKang6688 deleted the feat/build-without-systemjs branch April 21, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants