Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove sense legacy build path #1244

Merged
merged 1 commit into from May 3, 2023
Merged

feat: remove sense legacy build path #1244

merged 1 commit into from May 3, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Apr 25, 2023

Motivation

Cleans out the --legacy option for cli-sense.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele requested a review from a team April 25, 2023 11:53
@Caele Caele merged commit 6a5e34d into master May 3, 2023
6 of 8 checks passed
@Caele Caele deleted the tsm/clean-legacy branch May 3, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

@niekvanstaveren niekvanstaveren niekvanstaveren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Caele @veinfors @niekvanstaveren