Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: take empty field into account #1250

Merged
merged 2 commits into from
May 2, 2023
Merged

fix: take empty field into account #1250

merged 2 commits into from
May 2, 2023

Conversation

DanielS-Qlik
Copy link
Contributor

@DanielS-Qlik DanielS-Qlik commented Apr 27, 2023 •
edited
Loading

Motivation

Only show "No matches for your search" disclaimer when qCardinal is > 0.
Also trigger renderedCallback?.() when qCardinal is 0.
fixes qlik-oss/sn-list-objects#293
fixes qlik-oss/sn-list-objects#269

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@DanielS-Qlik DanielS-Qlik merged commit b11e9c9 into master May 2, 2023
@DanielS-Qlik DanielS-Qlik deleted the ild/empty-field branch May 2, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interaction disabled when empty field Listbox for empty field shows "There are no matches for your search."
2 participants
@DanielS-Qlik @veinfors