Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct usage of event-emitter #1258

Merged
merged 2 commits into from May 5, 2023
Merged

fix: correct usage of event-emitter #1258

merged 2 commits into from May 5, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented May 4, 2023

Motivation

Event emitter didn't actually have an off function, so switching to add/remove instead.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele requested review from eliseeborn and a team May 4, 2023 13:13
eliseeborn
eliseeborn approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@eliseeborn eliseeborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Caele Caele merged commit bac12a7 into master May 5, 2023
6 of 8 checks passed
@Caele Caele deleted the tsm/viz-emitter-upd branch May 5, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliseeborn eliseeborn eliseeborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Caele @eliseeborn