Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove storybook #1269

Merged
merged 2 commits into from May 15, 2023
Merged

chore: remove storybook #1269

merged 2 commits into from May 15, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented May 15, 2023

Motivation

We don't really use the storybook, so rather remove it to keep the alerts cleaner.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele requested a review from LiKang6688 May 15, 2023 08:20
Copy link
Contributor

@LiKang6688 LiKang6688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you rename .storybook to .storybook_old? Is it intentional to remain __stories__ folders?

@Caele
Copy link
Collaborator Author

Caele commented May 15, 2023

Why do you rename .storybook to .storybook_old? Is it intentional to remain __stories__ folders?

yea, just if we'd happen to change our minds, makes it a bit easier and doesn't really matter. The main issue I had was the dependency alerts, so wanted to get rid of those first.

@Caele Caele merged commit 626ff04 into master May 15, 2023
8 checks passed
@Caele Caele deleted the tsm/remove-storybook branch May 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants