Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types to nebula serve #658

Merged
merged 2 commits into from
Aug 31, 2021
Merged

feat: add types to nebula serve #658

merged 2 commits into from
Aug 31, 2021

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Aug 26, 2021

Motivation

Allows for the serve configuration to register extra types to the embed instance:

module.exports = {
  serve: {
    types: [{ name: 'barchart', url: "https://unpkg.com/@nebula.js/sn-bar-chart"}],
  },
};

This allows an chart to render the extra types using useEmbed.

Todo:

  • Docs
  • Tests?

@Caele Caele merged commit 29e8730 into master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants