Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook does not work #838

Merged
merged 4 commits into from May 31, 2022
Merged

fix: storybook does not work #838

merged 4 commits into from May 31, 2022

Conversation

LiKang6688
Copy link
Contributor

@LiKang6688 LiKang6688 commented May 30, 2022

Motivation

make storybook work again

@LiKang6688 LiKang6688 linked an issue May 30, 2022 that may be closed by this pull request
@LiKang6688 LiKang6688 requested a review from Caele May 30, 2022 13:32
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Comment on lines 57 to 60
- `yarn` installs all dependencies
- `yarn run build` generates UMD bundles for all packages and an ESM bundle for stardust
- `yarn run lint` checks code style
- `yarn run format` format code style
- `yarn run format` formats code style
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep as is.

Copy link
Collaborator

@Caele Caele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language comment, else looks good.

LiKang6688 and others added 2 commits May 31, 2022 08:50
Co-authored-by: Tobias Åström <tsm@qlik.com>
@LiKang6688 LiKang6688 merged commit 9f09d0b into master May 31, 2022
@LiKang6688 LiKang6688 deleted the fix/storybook branch May 31, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storybook does not work
2 participants