chore(dev-mashup): Fix broken yarn start #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you clean your commits a bit, please? |
LiKang6688
reviewed
Aug 15, 2022
| @@ -2,7 +2,7 @@ | |||
| "name": "local-mashup", | |||
| "version": "1.0.0", | |||
| "description": "Simple local mashup", | |||
| "main": "index.html", | |||
| "main": "index.js", | |||
There was a problem hiding this comment.
Do you know why the main is needed? I do not find the main section in https://github.com/qlik-oss/nebula.js/blob/master/commands/create/templates/mashup/_package.json.
There was a problem hiding this comment.
It's for npm or for the compiler/build tool to know which file is the entry point of the application. So no real use for it in this case. We could also remove it completely but it will still default to index.js which is why I decided to keep it (no strong opinion about it though).
There was a problem hiding this comment.
Very good to know. Then it is fine to keep it.
LiKang6688
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With parcel v.2 we need to explicitly specify type="module" for
<script>tags and cannot specify browser, module, main with an.htmlextension (parcel will throw an error).Reference: https://parceljs.org/blog/rc0/#improved-library-builds
Requirements checklist
yarn specOR
When build and tests have passed: