feat: add variable and expression support to serve props #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caele
commented
Aug 16, 2022
| @@ -142,7 +142,7 @@ export default function FieldsPopover({ alignTo, show, close, onSelected, type } | |||
| open={show} | |||
| onClose={close} | |||
| anchorEl={alignTo.current} | |||
| marginThreshold={theme.spacing(1)} | |||
| marginThreshold={16} // theme.spacing(1) | |||
Caele
commented
Aug 16, 2022
| @@ -24,7 +24,7 @@ const cfg = ({ srcDir, distDir, dev = false, serveConfig = {} }) => { | |||
| eHub: [path.resolve(srcDir, 'eHub')], | |||
| fixtures: [path.resolve(__dirname, './fixtures.js')], | |||
| }, | |||
| devtool: dev ? 'eval-cheap-module-source-map' : false, | |||
| devtool: dev ? 'source-map' : false, | |||
There was a problem hiding this comment.
Source maps wheren't working correctly.
|
I would expect that adding |
T-Wizard
reviewed
Aug 17, 2022
Same here, not sure why it doesn't. WIll look into it. Have been using the config file instead. EDIT: Commands give an array as ["PP_EXPRESSION"] while we want an object { PP_EXPRESSION: true } |
T-Wizard
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the cli-serve dev environment doesn't show property panel controls for all properties. For example all q-Props are skipped. This PR adds
Where value will be a qStringExpression trying to evaluate the variable.
Requirements checklist
yarn specOR
When build and tests have passed: