fix: return promise from cli-sense api #927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many uses already expect a promise
ex: https://github.com/qlik-oss/sn-scatter-plot/blob/36cf9ce948ac86d9f959f5b9ba62871cf4f065df/scripts/build.js#L39
That use is still OK as the missing promise is only needed when using a external ext file or use a legacy build.
Motivation
Requirements checklist
yarn spec
OR
When build and tests have passed: