chore!: set required node version #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes the next versions a breaking one. |
a-m-dev
approved these changes
Oct 21, 2022
veinfors
approved these changes
Oct 21, 2022
LiKang6688
reviewed
Oct 21, 2022
| @@ -10,7 +10,7 @@ | |||
| "keywords": ["qlik", "nebula", "stardust"], | |||
| "files": ["dist"], | |||
| "engines": { | |||
| "node": ">=8" | |||
| "node": ">=18" | |||
There was a problem hiding this comment.
why does node 16 not work?
There was a problem hiding this comment.
has to do with the new qlik/sdk we are using, specifically in nebula serve. It uses the new fetch APIs (think it was those) from node 18 and we run it on the webpack dev server (so authentication is done there, not in the browser).
18 will replace 16 as the version on long time support in a few days, so should be fine from that perspective.
There was a problem hiding this comment.
await fetch(). good stuff.
LiKang6688
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Requirements checklist
yarn specOR
When build and tests have passed: