Merge pull request #70 from qlik-oss/hva/modifiers-forward-3

fix(modifiers): only restore base if there is no base
qlik-oss · Feb 13, 2020 · 86094fc · 86094fc
2 parents ede5787 + df1c5ff
commit 86094fc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -634,7 +634,7 @@ function updateIfChanged({ oldProperties, newProperties, model }) {
   );
 }
 
-function findActiveModifier(measure) {
+function getBaseFromActiveModifier(measure) {
   const { modifiers } = measure.qDef;
   for (let i = 0; i < modifiers.length; i++) {
     const modifier = modifiers[i];
@@ -653,7 +653,9 @@ function applyMeasureModifiers({
 }) {
   let activeModifiersPerMeasure = 0;
   // For forward and backward compatibility
-  findActiveModifier(measure);
+  if (!measureBase.isValid(measure)) {
+    getBaseFromActiveModifier(measure);
+  }
   if (!measureBase.isValid(measure)) {
     measureBase.initBase(measure, true);
   }