This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
feat: add tooltips for cards #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caele
reviewed
Feb 6, 2020
eliseeborn
commented
Feb 10, 2020
eliseeborn
commented
Feb 10, 2020
Caele
reviewed
Feb 11, 2020
Caele
reviewed
Feb 11, 2020
Caele
reviewed
Feb 13, 2020
|
the only things now that maybe should be fixed:
|
niekvanstaveren
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Looks good. Let's get this in so I can continue with the zoom state. @haxxmaxx what do you think?
src/tree/box.js
Outdated
Comment on lines
111
to
115
| .on('mousedown', () => { | ||
| tooltip | ||
| .html('') | ||
| .attr('style', 'visibility: hidden;opacity: 0;'); | ||
| }); |
There was a problem hiding this comment.
This does not interfere with zoom/panning or making selections?
There was a problem hiding this comment.
This is mostly so that the tooltip will close when panning, though they can reopen, so it isn't very effective. The panning and selections do not seem to be affected.
haxxmaxx
reviewed
Feb 17, 2020
haxxmaxx
reviewed
Feb 17, 2020
haxxmaxx
reviewed
Feb 17, 2020
Caele
reviewed
Feb 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some basic tooltips containing all the card data
I know we have tooltips in sense, these should probably look the same as well