This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
fix: Path adjustment and expand multiple children whenever possible #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caele
reviewed
Feb 11, 2020
| heightMargin: buttonHeight + buttonMargin * 3, | ||
| leafMargin: 16, | ||
| buttonMargin, | ||
| buttonWidth: 48, // TODO: might need to be dynamic |
There was a problem hiding this comment.
you could probably just skip this, and instead set a max-width in css, just to avoid strange large cases.
EDIT: If you figure out a way to still centre them below the cards... without resorting to too many extra divs.
There was a problem hiding this comment.
Exactly, to center them becomes a problem if the css sets the width dynamically. I've tried and three digits fit, so we'll never need more than that if we have a sanity limit.
Caele
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched of my old branch, hence all the commits...