Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

Tsm/css select #57

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Tsm/css select #57

merged 4 commits into from
Feb 12, 2020

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Feb 12, 2020

Started with some css, ended up with refactoring selections a bit.

  • Added less support to clean up classes
  • divided the css into multiple files
  • changed selectors to be more specific
  • Removed some surplus elements, like extra divs holding paths and cards
  • Removed all instances of setting objects to the selections API
  • Correctly remove listeners to selections API using hook return function
  • updated nebbie

.sn-org-svg {
position: absolute;

.sn-org-link {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call them either links or paths, not both

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, paths it is

@Caele Caele merged commit ab22021 into master Feb 12, 2020
@Caele Caele deleted the tsm/css-select branch February 12, 2020 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants