Support for executing script from request without any data parameters #12
Conversation
| @@ -213,7 +213,10 @@ byte[] GetHeader(Metadata Headers, string Key) | |||
| paramnames += $" {param.Name}"; | |||
| } | |||
| logger.Info("{0}", paramnames); | |||
| await AddInputData(scriptHeader.Params.ToArray(), requestStream, rserveConn); | |||
| if (scriptHeader.Params != null && scriptHeader.Params.Count > 0) | |||
There was a problem hiding this comment.
Is it possible for Params to be null?
There was a problem hiding this comment.
Probably not since it will be an empty Collection with count 0 if no params are provided. I guess it was a habit to include a null check.
| @@ -40,10 +40,6 @@ | |||
| <HintPath>..\packages\Grpc.Core.1.2.2\lib\net45\Grpc.Core.dll</HintPath> | |||
| <Private>True</Private> | |||
| </Reference> | |||
| <Reference Include="NLog, Version=4.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c, processorArchitecture=MSIL"> | |||
There was a problem hiding this comment.
Is this include here not needed anymore? As far as I can see NLog is being used at least..
There was a problem hiding this comment.
The ServerSideExtension project does not use NLog. It is only the SSEtoRserve project that uses it.
NLog was not part of the packages.config but was referenced in the project file for some reason so I cleaned up that warning intentionally.
| @@ -40,10 +40,6 @@ | |||
| <HintPath>..\packages\Grpc.Core.1.2.2\lib\net45\Grpc.Core.dll</HintPath> | |||
| <Private>True</Private> | |||
| </Reference> | |||
| <Reference Include="NLog, Version=4.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c, processorArchitecture=MSIL"> | |||
There was a problem hiding this comment.
Is this an intentional cleanup?
There was a problem hiding this comment.
The ServerSideExtension project does not use NLog. It is only the SSEtoRserve project that uses it.
NLog was not part of the packages.config but was referenced in the project file for some reason so I cleaned up that warning intentionally.
Fixes #[issue number].
Status
Information
To-do list