Return table #25
Return table #25
Conversation
…n, including TableDescription header.
… added new defined function in R plugin called SumAndMulOfRow that returns two columns.
tobiaslindulf
requested review from
Bjornwa,
josefinestal and
LinneaStovring-Nielsen
| message TableDescription { | ||
| repeated FieldDescription fields = 1; /// The fields of the table. | ||
| string name = 2; /// The name of the table. | ||
| int64 numberOfRows = 3; /// Number of rows in table. |
There was a problem hiding this comment.
To be consistent with the rest of the comments, you might want to use "The number of rows in the table." instead.
There was a problem hiding this comment.
Good catch, this change must be updated on master and in qlik-oss/server-side-extentions as well, if we choose to correct it.
There was a problem hiding this comment.
No we wait with this change since it is too small and does not justify the work. We change it in future versions.
| else if (resultDataColumns[col].DataType == DataType.String) | ||
| { | ||
| row.Duals.Add(new Dual() { StrData = resultDataColumns[col].Strings[i] ?? "" }); | ||
| } |
There was a problem hiding this comment.
Do you want to support returning dual data? (if set in tableDescription) If not, you might want to throw an error.
There was a problem hiding this comment.
No, we only get one type from Rserve so it will not be possible. I will think about what should be done.
There was a problem hiding this comment.
I have tested to set the return values in all the defined functions to Dual, then run the example when only getting numerics or strings from Rserve. We actually send an error from the plugin to Qlik in this case since the data type of the first column differs from the definition (see code lines 549-554). Therefore no changes needed, all works as expected.
docs/versions.md
Outdated
| @@ -3,5 +3,6 @@ The table below is showing all released SSE R-plugin versions and which SSE prot | |||
|
|
|||
| | __R-plugin Version__ | __SSE Protocol Version__ | __Qlik Sense Version__ | __QlikView Version__ | | |||
| | ----- | ----- | ----- | ----- | | |||
| | [v1.2.0](https://github.com/qlik-oss/sse-r-plugin/releases/tag/v1.2.0) | [v1.1.0](https://github.com/qlik-oss/server-side-extension/releases/tag/v1.1.0) | Qlik Sense Feb 2018 release | QlikView does not use this yet | | |||
There was a problem hiding this comment.
Just a matter of preferences :) , but I would say SSE v1.1.0 is not supported in QV (or similar), rather than "..does not use this yet."
There was a problem hiding this comment.
correct, I was thinking about that even if QlikView is not yet using SSE v1.1.0 yet it is still possible for QV to use and connect to a plugin that is supporting v1.1.0 . But I think I change the text here and put the "backwards compatibility" description in the release notes instead.
|
Otherwise, it looks good! (approved) |
Support for returning a table (R data.frame or matrix) from the plugin to Qlik.
Status
Information
To-do list