Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty cells is missing from pod install version in DropDownMenu class #22

Closed
hamtiko opened this issue Oct 19, 2017 · 2 comments

Comments

@hamtiko
Copy link

hamtiko commented Oct 19, 2017

Hello,

Thanks for nice lib.
Yesterday I have faced following issue.
In the GitHub version in master branch I have noticed that in DropDownMenu.swift file line 156 there is if statement for checking empty cell case before scrolling tableview:

	contentView.frame.size.height = menuView.frame.height

	// Reset scroll view content offset after rotation
	if menuView.visibleCells.isEmpty {
			return
		}
	menuView.scrollToRow(at: IndexPath(row: 0, section: 0), at: .top, animated: false)

But when I have pod install on my project I notice that this statement is missing from source code and it cause exception at runtime when DropDownMenu does not have any cell.

Could you please help me get last version via pod install?

My podfile is:
pod 'DropDownMenuKit'

@tigran-stdev
Copy link

I have found the overcome to this issue. Using git url in podfile will force pod to use latest version from master branch:

pod 'DropDownMenuKit', :git => 'https://github.com/qmathe/DropDownMenuKit.git'

@qmathe
Copy link
Owner

qmathe commented Oct 18, 2018

Hi,

I made a new release 0.8.5 for Swift 4.1 that includes this fix. For Swift 4.2 support, you can use master as suggested by @tigran-stdev. I'm going to make a new release soon based on master.

@qmathe qmathe closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants