-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for HID Bootloader generation #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I finally got around to testing this, on a Pro Micro - speaker and LED work 👍 Toolbox doesn't know what to do with it, of course, it thinks it's a DFU device because of the VID, but that can easily be sorted out.
Small disappointing thing: because Windows gives this the HidUsb
driver, the vendor and product strings don't show up. We'll need to get these strings using HidLibrary or something similar for the Windows toolbox.
Otherwise, LGTM 🎉
Would like to get this in this breaking changes cycle. |
Conflict on gitignore now. |
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
9cf7692
to
b2efce1
Compare
Done. |
From the looks of it, it works exactly like the halfkay bootloader, just ... larger. There is included source for creating a version of teensy_loader_cli that supports both device types, but it's also outdated. I have updated code, and ... may should add it here too. |
Also, done now. Additionally, it would be trivial to add a different VID/PID combo to the cli |
Hmm, this is compiling over 2kb for me. I think it is supposed to come in under that. The at90usb1286 config does come in under 4096 by a good margin, though. |
Nah, the boot section size in the makefile is set to 4kB. I think this would be the case for all of the LUFA bootloader, except of course the mass storage one. |
Okay, wasn't entirely sure. |
3013985
to
b2efce1
Compare
This is from qmk_firmware#2479 which adds the ability to generate a HID Bootloader for boards.
Additionally, this ports the pin mapping from config_common, so that it's more accurate and supports more boards.