Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymap presentation is broken for very tall keyboards #3

Closed
dudeofawesome opened this issue Jan 13, 2018 · 2 comments
Closed

Keymap presentation is broken for very tall keyboards #3

dudeofawesome opened this issue Jan 13, 2018 · 2 comments

Comments

@dudeofawesome
Copy link

image

It looks like it is assumed that a keymap will be no taller than the layer picker.

@yanfali
Copy link
Collaborator

yanfali commented Jun 3, 2018

I think the best way of dealing with this would be to add a info.json that overrides the default layout from the header files.

@yanfali
Copy link
Collaborator

yanfali commented Apr 8, 2019

This should be fixed with the current configurator. Thanks for reporting.

@yanfali yanfali closed this as completed Apr 8, 2019
yanfali pushed a commit that referenced this issue Jun 13, 2019
* Add international backslash

* delete useless log

* add possibility to switch between layouts

* keycode fix

* delete comment

* fix n refactor

* cleanup

* A different way to organize the code lookup table (#2)

* A different way to organize the code lookup table

* Rename

* Row org

* Extract layouts

 - use import name rather than aliases

* Simplify Layouts

* Reset keymap before switching layout

* move getQMKCode into vuex getter

* Encapsulate knowledge of internals

 - remove dependency on knowing the internals of store

* reduce code

* Better naming

* lint / handle default layout / radio buttons

* lint

* Update comments for slice of ISO (#3)

* Update comments for slice of ISO

* Linting

* review

* review
jceb pushed a commit to jceb/qmk_configurator that referenced this issue Sep 12, 2019
* Add international backslash

* delete useless log

* add possibility to switch between layouts

* keycode fix

* delete comment

* fix n refactor

* cleanup

* A different way to organize the code lookup table (qmk#2)

* A different way to organize the code lookup table

* Rename

* Row org

* Extract layouts

 - use import name rather than aliases

* Simplify Layouts

* Reset keymap before switching layout

* move getQMKCode into vuex getter

* Encapsulate knowledge of internals

 - remove dependency on knowing the internals of store

* reduce code

* Better naming

* lint / handle default layout / radio buttons

* lint

* Update comments for slice of ISO (qmk#3)

* Update comments for slice of ISO

* Linting

* review

* review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants