Add Missing Keyboard Settings keycodes #1204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `CL_TOGG`: Toggle Caps Lock and Left Control swap - `GUI_TOG`: Toggles the status of the GUI keys - `NK_TOGG`: Toggle N-key rollover - `AG_TOGG`: Toggle Alt and GUI swap on both sides - `CG_TOGG`: Toggle Control and GUI swap on both sides - `EC_SWAP`: Swap Caps Lock and Escape - `EC_TOGG`: Toggle Caps Lock and Escape swap - `EC_NORM`: Unswap Caps Lock and Escape - `EH_LEFT`: Set the master half of a split keyboard as the left hand (for EE_HANDS) - `EH_RGHT`: Set the master half of a split keyboard as the right hand (for EE_HANDS)
|
Went for an Enable-Toggle-Disable layout, by rows:
|
noroadsleft
commented
Nov 9, 2022
Comment on lines
+105
to
+113
| { | ||
| width: 3000 | ||
| }, | ||
| { | ||
| width: 3000 | ||
| }, | ||
| { | ||
| width: 1500 | ||
| }, |
There was a problem hiding this comment.
Not sure how I feel about this bit...
There was a problem hiding this comment.
You could create an alias to an object like so:
const blank3000Row = { width: 3000 };
and then use it like so:
...blank3000Rowor without the spread operator depending on how you surround it
There was a problem hiding this comment.
The issue I'm having with this is that I need a space that's 7.5 key units, but there isn't a spacer class in the CSS for one.
I could add one of course, but I don't think that's a scalable solution.
yanfali
reviewed
Nov 9, 2022
| name: 'Swap Caps/Esc', | ||
| code: 'EC_SWAP', | ||
| title: 'Swap Caps Lock and Escape', | ||
| width: 1500 |
There was a problem hiding this comment.
if we're using the same width in a lot of places, you can replace this with a constant.
yanfali
approved these changes
Nov 9, 2022
|
@noroadsleft merge if you're happy with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following keycodes to QMK Configurator:
CL_TOGG: Toggle Caps Lock and Left Control swapGUI_TOG: Toggles the status of the GUI keysNK_TOGG: Toggle N-key rolloverAG_TOGG: Toggle Alt and GUI swap on both sidesCG_TOGG: Toggle Control and GUI swap on both sidesEC_SWAP: Swap Caps Lock and EscapeEC_TOGG: Toggle Caps Lock and Escape swapEC_NORM: Unswap Caps Lock and EscapeEH_LEFT: Set the master half of a split keyboard as the left hand (for EE_HANDS)EH_RGHT: Set the master half of a split keyboard as the right hand (for EE_HANDS)