Error compiling firmware with KEY_LOCK_ENABLE=yes with possible fix.

[fnurl]

I wanted to enable the Key Lock feature for my Planck layout and added

KEY_LOCK_ENABLE = yes

to my rules.mk which gave me the following error when compiling:

Linking: .build/planck_rev4_fnurlspace.elf                                                          [ERRORS]
 |
 | .build/obj_planck_rev4_fnurlspace/quantum/process_keycode/process_key_lock.o: In function `process_key_lock':
 | /Users/jodfo01/github/qmk/qmk_firmware/quantum/process_keycode/process_key_lock.c:92: undefined reference to `translate_keycode'
 | collect2: error: ld returned 1 exit status
 |
make[1]: *** [.build/planck_rev4_fnurlspace.elf] Error 1
make: *** [planck-rev4-fnurlspace-all] Error 1
Make finished with errors

I'm running avr-gcc (GCC) 7.2.0 installed using homebrew on OS X 10.11.6.

I am not a C programmer, but made the following change to process_key_lock_.c which fixed the issue for me.

diff --git a/quantum/process_keycode/process_key_lock.c b/quantum/process_keycode/process_key_lock.c
index d7978f91..50cc0a5c 100644
--- a/quantum/process_keycode/process_key_lock.c
+++ b/quantum/process_keycode/process_key_lock.c
@@ -51,7 +51,7 @@ uint64_t key_state[4] = { 0x0, 0x0, 0x0, 0x0 };
 bool watching = false;

 // Translate any OSM keycodes back to their unmasked versions.
-uint16_t inline translate_keycode(uint16_t keycode) {
+static inline uint16_t translate_keycode(uint16_t keycode) {
     if (keycode > QK_ONE_SHOT_MOD && keycode <= QK_ONE_SHOT_MOD_MAX) {
         return keycode ^ QK_ONE_SHOT_MOD;
     } else {

[sunwooOh]

Had the same error, @fnurl's solution worked for me too.

[drashna]

Fixed in #1909. Closing.