Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireless tri-mode boards + lack of source code #24085

Open
tzarc opened this issue Jul 10, 2024 · 4 comments
Open

Wireless tri-mode boards + lack of source code #24085

tzarc opened this issue Jul 10, 2024 · 4 comments

Comments

@tzarc
Copy link
Member

tzarc commented Jul 10, 2024

TL:DR; Vendors who submit PRs whilst not providing full sources for all of their shipping boards will be put on hold until source code for all violating keyboards are provided.

If QMK identifies any licensing violation, all current and future PRs from that manufacturer will be put on hold until sources are provided. QMK's license requires full disclosure of source code for any firmware which is based on QMK, includes any part of QMK, or derives from QMK in any way. This source code disclosure is not negotiable and is automatically agreed to by any designer when they choose to use QMK.

Given the recent ramping-up of Chinese vendors disregarding QMK's license, QMK now actively chooses to prevent merges when violations are found.

Vendors may rectify the situation by providing full source code for their boards, even if it's in their own fork of QMK Firmware.

Current list of vendors who need to provide source code before any new PRs will be considered:

  • Royal Kludge
  • Epomaker
  • KiiBOOM
  • Tacworks
  • mmd
  • owlab
  • qwertykeys

Royal Kludge has issued a bunch of PRs recently with significant ambiguity as to whether or not submitted keyboards are tri-mode wireless or not.
So far there has been insufficient evidence supplied stating "no", they're wired-only boards -- comments on PRs when querying this fact have been ambiguous at best.

Additionally, with the fact that Royal Kludge is currently distributing VIA definitions for tri-mode keyboards based on QMK here -- including the rk839, also known as RK-R65, which shares the Product ID 0xE453 listed in PR #23559, we can only assume that Royal Kludge is submitting wired board definitions to QMK in order to satisfy VIA's requirement that keyboards must exist in QMK's master branch, with no intention to supply source code for wireless boards as per QMK's licensing requirements.

As of the posting of this issue, QMK is putting a hold on all PRs from vendor ID 0x342D until all sources are made available for the corresponding QMK-based boards listed on the above page (inclusive of wireless bindings where relevant):

  • RK61 QMK Wired RGB ANSI (PID 0x6461)
  • R65 QMK/VIA Tri-Mode RGB ANSI (PID 0xE453)
  • R65 QMK/VIA Tri-Mode RGB ISO (PID 0xE47F)
  • R65 QMK/VIA Wired RGB ANSI (PID 0xE453)
  • R65 QMK/VIA Wired RGB ISO (PID 0xE480)
  • R75 QMK/VIA Wired RGB ANSI (PID 0xE484)
  • R75 QMK/VIA Wired RGB ISO (PID 0xE483)
  • R75Pro QMK/VIA Tri-Mode RGB ANSI (PID 0xE487)
  • R75Pro QMK/VIA Tri-Mode RGB ISO (PID 0xE485)

Additionally, the VIA definitions on the same page also list the following combinations which also need full sources provided, including wireless:

  • R75Pro QMK (Tri-mode) - vendor ID 0xBB3F, product ID 0x0001
  • R75 QMK (Tri-mode) - vendor ID 0x342D, product ID 0xE482

image
image

@tzarc
Copy link
Member Author

tzarc commented Jul 10, 2024

For clarity, the vendor ID is Westberry Technology, which is also in use by Epomaker, KiiBOOM and others.
There is sufficient evidence that these manufacturers are all subcontracting out to the same third-party firmware provider - @sdk66 seems to be listed as maintainer for all.

Manufacturers other than Royal Kludge are also going to be put on hold for this reason -- the third-party firmware provider must supply source code for all QMK-based boards.

This was referenced Jul 10, 2024
@tzarc tzarc mentioned this issue Jul 14, 2024
14 tasks
@tzarc tzarc changed the title Royal Kludge tri-mode licensing issues Wireless tri-mode boards + lack of source code Jul 14, 2024
@tzarc
Copy link
Member Author

tzarc commented Jul 14, 2024

mmd added to the list of vendors who now require source code disclosure before any future boards are merged.

Two of the three boards listed on their site (http://www.i-game.tech/qmkjpxl) are tri-mode and are seemingly based on QMK:

image
image
image

@tzarc tzarc pinned this issue Jul 14, 2024
@drashna drashna mentioned this issue Jul 16, 2024
14 tasks
@drashna
Copy link
Member

drashna commented Jul 16, 2024

Qwertykeys, owlab, neo appear to be selling QMK+via compatible keyboards with tri-mode
https://www.qwertykeys.com/pages/fw

on each page with tri-mode wireless keyboards, even with tri-mode selected:

All PCBs support VIA and the wired features are based on QMK.

@tzarc
Copy link
Member Author

tzarc commented Jul 16, 2024

Regarding Qwertykeys, all links to JSON are to VIA firmware json definitions, thus either fully or partially based on QMK and thus subject to the QMK license.

image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants