Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create rk839us.json #2249

Closed
wants to merge 3 commits into from
Closed

create rk839us.json #2249

wants to merge 3 commits into from

Conversation

sdk66
Copy link

@sdk66 sdk66 commented Apr 19, 2024

create rk839us.json,frist commit

Description

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

create rk839us.json,frist commit
update rk839us.json
@Cipulot
Copy link
Collaborator

Cipulot commented Apr 19, 2024

@sdk66 not sure if you wanted to push on your fork....
If the intention was to have the board merged in the main repo then I suggest you to read the PR Checklist carefully and get back to this.

@Cipulot Cipulot added invalid This doesn't seem right blocked labels Apr 19, 2024
@sdk66
Copy link
Author

sdk66 commented Apr 19, 2024

不确定你是否想推你的叉子......如果打算将董事会合并到主存储库中,那么我建议您仔细阅读 PR 清单并返回此主题。

@sdk66 not sure if you wanted to push on your fork.... If the intention was to have the board merged in the main repo then I suggest you to read the PR Checklist carefully and get back to this.

I'm now trying to merge my json file into the repository, thank you for your comments, I'll try again to read the docs and upload them

Upload it after re-editing
@Cipulot
Copy link
Collaborator

Cipulot commented Apr 28, 2024

the PR still has issues. First with the PR checklist not being followed...
Furthermore, there's no match between the naming of what you are trying to merge...

  • PR Title: rk839us
  • json file name: rk839.json
  • board name within the file: RK-R65

Like.... what are you even trying to merge at this point.

@Cipulot Cipulot mentioned this pull request Apr 28, 2024
7 tasks
@Cipulot
Copy link
Collaborator

Cipulot commented Jul 10, 2024

qmk/qmk_firmware#24085

@Cipulot Cipulot closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants