Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is31fl3733 support: DRIVER_COUNT 1 not compiling #3797

Closed
ykabbani opened this issue Aug 30, 2018 · 2 comments
Closed

is31fl3733 support: DRIVER_COUNT 1 not compiling #3797

ykabbani opened this issue Aug 30, 2018 · 2 comments
Labels
bug enhancement help wanted question

Comments

@ykabbani
Copy link

ykabbani commented Aug 30, 2018 •
edited

@yiancar @drashna

makefile is only compiling when I set driver_count to 2, even though both drivers are addressed (same address since only one driver)

Btw, I coudn't get it to work.
@drashna
Copy link
Member

drashna commented Aug 30, 2018 •
edited

Yup, talked about this in discord.

@yiancar
Copy link
Contributor

yiancar commented Aug 30, 2018

Yes for now just leave it at 2. the second address you define is not used anyway. This is because atm the driver is not clever enough to know what to do. This will be fixed in the future, possibly when someone actually needs to use 2 drivers

@BenRoe BenRoe mentioned this issue Feb 19, 2019
Merged
13 tasks
zer09 pushed a commit to zer09/qmk_firmware that referenced this issue Mar 2, 2019
@BenRoe @zer09
[Docs] Fix typo in RGB Matrix Driver configuration (qmk#5182)
59d5182 
* Fix qmk#3797 firmware not compiling

If DRIVER_COUNT 1 firmware will not compile.

* Fix typo
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this issue Mar 7, 2019
@BenRoe
[Docs] Fix typo in RGB Matrix Driver configuration (qmk#5182)
e29527f 
* Fix qmk#3797 firmware not compiling

If DRIVER_COUNT 1 firmware will not compile.

* Fix typo
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this issue Apr 3, 2019
@BenRoe
[Docs] Fix typo in RGB Matrix Driver configuration (qmk#5182)
f1392eb 
* Fix qmk#3797 firmware not compiling

If DRIVER_COUNT 1 firmware will not compile.

* Fix typo
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this issue May 24, 2019
@BenRoe
[Docs] Fix typo in RGB Matrix Driver configuration (qmk#5182)
a1db275 
* Fix qmk#3797 firmware not compiling

If DRIVER_COUNT 1 firmware will not compile.

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drashna @yiancar @ykabbani