NO_ACTION_TAPPING disables layers

[jandk]

I was just playing around for fun, because I'm probably going to use taps at one point. But defining NO_ACTION_TAPPING disables the layer switching. Even with MO

[drashna]

That's odd.

I can confirm that MO is disabled, but .... TG is not.

Oh, okay. MO is technically ACTION_LAYER_TAP((layer), OP_ON_OFF). So, we'd need to more finely ifdef it...

qmk_firmware/tmk_core/common/action.c

Line 457 in c5221fa

case OP_ON_OFF:

[jandk]

Good to know, thought I went crazy for a minute 😊

[drashna]

I mean, crazy is always a possibility, but this is definitely an unintended effect.

I'll see about fixing this, if i can.

[me0wday]

I was running into this issue as well, Clueboard 66 Hotswap prototype (atmega32u4), NO_ACTION_TAPPING was defined by default for this keyboard, so I had to undef it to enable my MO() layer tapping as well as LT() layer switching.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

[tzarc]

Closing due to inactivity.

[rileyjshaw]

@tzarc should this be closed yet? @drashna is still actively working on a PR: #11528.

[tzarc]

@tzarc should this be closed yet? @drashna is still actively working on a PR: #11528.

Was doing cleanup overall -- last activity on this issue was 3 years ago.

If we reopen it, it's going to get closed by stalebot after 120 days anyway -- if nobody has commented or updated this in 3 years I doubt another 4 months will be any different.

Besides, in my view there's no real need to keep this open if there's already a PR in progress. It's already being "tracked" in one way or another.

[rileyjshaw]

Cool, makes sense to me!

On Sat, Jun 18, 2022 at 16:08 Nick Brassel ***@***.***> wrote: @tzarc <https://github.com/tzarc> should this be closed yet? @drashna <https://github.com/drashna> is still actively working on a PR: #11528 <#11528>. Was doing cleanup overall -- last activity on this issue was 3 years ago. If we reopen it, it's going to get closed by stalebot after 120 days anyway -- if nobody has commented or updated this in 3 years I doubt another 4 months will be any different. Besides, in my view there's no real need to keep this open if there's already a PR in progress. It's already being "tracked" in one way or another. — Reply to this email directly, view it on GitHub <#5735 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOBNVWFGJ6H2PUZESKOGYLVPYUFPANCNFSM4HJF57VA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Sent from my mobile.

[arretxe]

Not sure how much code size NO_ACTION_TAPPING saves, but I need Layers and not ACTION_TAPPING so I would really be itnerested in having this corrected, maybe I can try myself looking where the NO_ACTIONG_TAPPING ifdefs are