Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual serial is not documented #9131

Closed
iFreilicht opened this issue May 18, 2020 · 14 comments
Closed

Virtual serial is not documented #9131

iFreilicht opened this issue May 18, 2020 · 14 comments

Comments

@iFreilicht
Copy link
Contributor

We have a virtual serial port available since 2016 (#677), and the stenography features are using it, yet it doesn't seem to be documented anywhere and only one keymap is using the virtser_recv for receiving commands from the PC, something that seems to be asked about every now and then.

It seems it's as easy as adding VIRTSER_ENABLE = yes to rules.mk, a line that is not present in any example file, and then defining virtser_recv in your keymap.c.

If I got the structure of the docs right, this new page should go into the "Software Features" section.

@drashna
Copy link
Member

drashna commented May 20, 2020

Yup to just about all of that. The send/receive stuff should work very much like how the raw HID does. So a lot of the code should be convertible.

@stale
Copy link

stale bot commented Aug 18, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 18, 2020
@stapelberg
Copy link
Contributor

@Stale: this issue is still relevant

@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 22, 2020
@iFreilicht
Copy link
Contributor Author

iFreilicht commented Aug 22, 2020 via email

@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 21, 2020
@stapelberg
Copy link
Contributor

@Stale: this issue is still relevant

@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 21, 2020
@stale
Copy link

stale bot commented Feb 21, 2021

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 21, 2021
@stapelberg
Copy link
Contributor

@Stale: this issue is still relevant

@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Feb 22, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 2, 2021
@danshick
Copy link

danshick commented Jun 2, 2021

@Stale This issue is still relevant.

@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 2, 2021
@zvecr
Copy link
Member

zvecr commented Aug 29, 2022

This issue has been automatically closed because it has not had any recent activity.
If this issue is still valid, re-open the issue and let us know.

@zvecr zvecr closed this as completed Aug 29, 2022
@iFreilicht
Copy link
Contributor Author

@zvecr This issue is not fixed yet and it is still active. The missing documentation has not been written.

@keyboard-magpie
Copy link
Contributor

I'll have a go at this in two months, until then I'm hard pressed for time. 22 Aug 2020 20:25:45 Michael Stapelberg notifications@github.com:

@Stale[https://github.com/Stale]: this issue is still relevant — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[#9131 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ACKKSK3O3PDJ25ETCDWYYY3SCAESPANCNFSM4NEI7ZNQ]. [https://github.com/notifications/beacon/ACKKSK2LD7LDGRMZ4JESLELSCAESPA5CNFSM4NEI7ZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFBZ4FPY.gif]

If it's not happened in 2 years, is it going to happen at all? Issues shouldn't remain open indefinitely and this was closed as part of a cleanup.

@PeterHindes
Copy link
Contributor

I'll see if I can figure out how it works. No promises though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants