olligranlund keymap updates for DZ60 and Keebio/Iris #10760
Conversation
|
In its current form, this PR cannot be accepted due to the submodule changes in |
|
I guess I had an too old version of qmk fork, merged now from upstream latest master |
|
Still no good. You want it so the files changed tab cant see a change, then the bot will remove the 'dependencies' label. |
|
Updated all the submodules with this command:
|
|
Now you have |
|
Apparently updating the submodules turned out to be trickier than I expected... Where do we have stated which versions of the submodules should be used? I redownloaded QMK and replaced the lib-folder with the latest generated by qmk, but still running into the same issue... Any hints on how I should proceed? |
|
Got some help from QMK discord to cleanup the repo, no changes to git submodules anymore :) |
|
|
||
| /* Select hand configuration */ | ||
|
|
||
| // #define MASTER_LEFT | ||
| #define MASTER_LEFT |
There was a problem hiding this comment.
Technically, this isn't required, as it's the default behavior.
| enum layers ( | ||
| _QWERTY, | ||
| _LOWER, | ||
| _RAISE |
There was a problem hiding this comment.
Fixing two typos; this keymap doesn't compile without these fixes.
| enum layers ( | |
| _QWERTY, | |
| _LOWER, | |
| _RAISE | |
| enum layers { | |
| _QWERTY, | |
| _LOWER, | |
| _RAISE, |
| ADJUST, | ||
| }; | ||
|
|
||
| #define KC_ KC_TRNS |
There was a problem hiding this comment.
This should be removed, as it doesn't appear to be used.
| #define KC_ KC_TRNS |
| #include "config_common.h" | ||
|
|
||
| /* USB Device descriptor parameter */ | ||
| #define VENDOR_ID 0x2602 |
There was a problem hiding this comment.
This vendor ID is already in use.
https://www.the-sz.com/products/usbid/index.php?v=0x2602&p=&n=
❯ echo -n "Oliver Granlund" | shasum | cut -c1-4 | tr '[:lower:]' '[:upper:]'
B9F7
| #define VENDOR_ID 0x2602 | |
| #define VENDOR_ID 0xB9F7 |
Or if you want to use ascii
| #define VENDOR_ID 0x2602 | |
| #define VENDOR_ID 0x4F47 // "OG" |
| case QWERTY: | ||
| if (record->event.pressed) { | ||
| set_single_persistent_default_layer(_QWERTY); | ||
| } | ||
| return false; | ||
| break; |
There was a problem hiding this comment.
This isn't needed, since you only have the one default layer.
I've reworked my keymaps for both Iris and DZ60.
DZ60
I created a new keymap for my second DZ60 board which has a different layout than my first one. Added VIA support.
Keebio/Iris
I created a new keymap for the rebuild of my Iris board. This layout differs to some extent from the original and tries to be more inline with any normal 60% ISO keyboard. Added VIA support.
Description
The changes done are only keymap changes to keymaps which I've uploaded earlier.
Types of Changes
Checklist