Remove MIDI Configuration boilerplate #11151

noroadsleft · 2020-12-08T00:56:21Z

Description

Removes the MIDI configuration options and MIDI_ENABLE = no statements from keyboard-level files where MIDI is disabled. No changes in functionality, just removing code from places where it isn't needed.

This can probably go safely to the master branch, but I have it on develop for now.

Types of Changes

Enhancement/optimization
Keyboard (addition or update)

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
I have read the CONTRIBUTING document.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

stale · 2021-02-21T22:23:44Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

tzarc · 2021-02-27T20:34:56Z

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

stale · 2021-06-02T15:29:57Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

stale · 2021-07-08T01:46:50Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

fauxpark · 2021-07-09T04:35:18Z

Looks good except for submodule changes.

noroadsleft · 2021-07-09T21:43:28Z

@fauxpark Thank you, and fixed. 👍

Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} + ``` Co-Authored-By: Nick Brassel <nick@tzarc.org>

Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} + ```

Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} + ```

Aligns the inline comments to the length used by the QMK AVR rules.mk template. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} + ```

…files Commands: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} + find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} + find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} + ```

* remove keyboard-level instances of `MIDI_ENABLE = no` Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} + ``` Co-Authored-By: Nick Brassel <nick@tzarc.org> * fix case-sensitivity issues on MIDI_ENABLE Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} + ``` * replace `# MIDI controls` with `# MIDI support` Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} + ``` * align inline comments Aligns the inline comments to the length used by the QMK AVR rules.mk template. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} + ``` * remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files Commands: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} + find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} + find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} + ``` * remove MIDI configuration boilerplate from keyboard config.h files Co-authored-by: Nick Brassel <nick@tzarc.org>

github-actions bot added the keyboard label Dec 8, 2020

noroadsleft force-pushed the clean/midi branch from be07ad5 to fdbee87 Compare January 7, 2021 08:31

stale bot added the awaiting changes label Feb 21, 2021

tzarc closed this Feb 27, 2021

tzarc deleted the branch qmk:develop February 27, 2021 20:28

tzarc reopened this Feb 27, 2021

stale bot removed the awaiting changes label Feb 27, 2021

noroadsleft force-pushed the clean/midi branch from fdbee87 to d3a693c Compare February 28, 2021 09:52

drashna approved these changes Mar 14, 2021

View reviewed changes

stale bot added the awaiting changes label Jun 2, 2021

stale bot closed this Jul 8, 2021

tzarc reopened this Jul 8, 2021

stale bot removed the awaiting changes label Jul 8, 2021

noroadsleft force-pushed the clean/midi branch from d3a693c to f92ee0c Compare July 9, 2021 00:47

github-actions bot added the dependencies label Jul 9, 2021

github-actions bot removed the dependencies label Jul 9, 2021

fauxpark approved these changes Jul 10, 2021

View reviewed changes

noroadsleft force-pushed the clean/midi branch from 2ec4765 to 3603d8d Compare August 5, 2021 23:56

noroadsleft force-pushed the clean/midi branch from 3603d8d to 6393c83 Compare August 15, 2021 05:43

noroadsleft and others added 5 commits August 15, 2021 00:27

remove keyboard-level instances of MIDI_ENABLE = no

7ba9a7a

Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} + ``` Co-Authored-By: Nick Brassel <nick@tzarc.org>

fix case-sensitivity issues on MIDI_ENABLE

ae9527c

Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} + ```

align inline comments

b266cbb

Aligns the inline comments to the length used by the QMK AVR rules.mk template. Command: ``` find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} + ```

remove MIDI configuration boilerplate from keyboard config.h files

06f843a

noroadsleft force-pushed the clean/midi branch from 6393c83 to 06f843a Compare August 15, 2021 07:41

noroadsleft marked this pull request as ready for review August 15, 2021 07:49

noroadsleft added the breaking_2021q3 label Aug 15, 2021

tzarc approved these changes Aug 15, 2021

View reviewed changes

tzarc merged commit 4b453dc into qmk:develop Aug 15, 2021

noroadsleft deleted the clean/midi branch August 15, 2021 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Remove MIDI Configuration boilerplate #11151

Remove MIDI Configuration boilerplate #11151

Uh oh!

noroadsleft commented Dec 8, 2020

Uh oh!

stale bot commented Feb 21, 2021

Uh oh!

tzarc commented Feb 27, 2021

Uh oh!

stale bot commented Jun 2, 2021

Uh oh!

stale bot commented Jul 8, 2021

Uh oh!

fauxpark commented Jul 9, 2021

Uh oh!

noroadsleft commented Jul 9, 2021

Uh oh!

Uh oh!

Uh oh!

Remove MIDI Configuration boilerplate #11151

Remove MIDI Configuration boilerplate #11151

Uh oh!

Conversation

noroadsleft commented Dec 8, 2020

Description

Types of Changes

Checklist

Uh oh!

stale bot commented Feb 21, 2021

Uh oh!

tzarc commented Feb 27, 2021

Uh oh!

stale bot commented Jun 2, 2021

Uh oh!

stale bot commented Jul 8, 2021

Uh oh!

fauxpark commented Jul 9, 2021

Uh oh!

noroadsleft commented Jul 9, 2021

Uh oh!

Uh oh!