Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of last matrix activity #11552

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 15, 2021

Description

Re-submission of #10730 -- there was a logic issue that only seemed to manifest on some AVR builds.
@daskygit has graciously performed the investigation on their end, as I was unable to reproduce.

This PR adds support for recording the last time matrix activity was detected.
Two new APIs have been added:

uint32_t last_matrix_activity_time(void);     // Timestamp of the last matrix activity
uint32_t last_matrix_activity_elapsed(void);  // Number of milliseconds since the last matrix activity

These values are compatible with normal matrix scanning, as well as split_common.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team January 15, 2021 00:35
@github-actions github-actions bot added the core label Jan 15, 2021
Co-authored-by: Dasky <daskygit@users.noreply.github.com>
@drashna drashna requested a review from a team January 15, 2021 06:34
@tzarc tzarc marked this pull request as draft January 17, 2021 17:49
@tzarc tzarc marked this pull request as ready for review January 17, 2021 17:56
@tzarc
Copy link
Member Author

tzarc commented Jan 17, 2021

Ignore the draft toggle -- mistakenly thought I'd lost the changes for non-split code... they were there already.

@tzarc tzarc merged commit e702c7f into qmk:develop Jan 17, 2021
@tzarc tzarc deleted the last-matrix-activity-take2 branch January 17, 2021 18:01
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Co-authored-by: Dasky <daskygit@users.noreply.github.com>

Co-authored-by: Dasky <daskygit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants