Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues when manually shifting characters and Auto Shift #12083

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix issues when manually shifting characters and Auto Shift #12083

merged 1 commit into from
Mar 25, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Mar 2, 2021

Specifically, when using the Auto-Shift feature, if you hold and roll shift, it would not actually shift the character that you hit after the shift.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

  • Reported from ZSA

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Fix issues when manually shifting characters and Auto Shift
5b2a5a2 
Specifically, when using the Auto-Shift feature, if you hold and roll shift, it would not actually shift the character that you hit after the shift
@drashna drashna requested a review from a team March 2, 2021 16:36
@github-actions github-actions bot added the core label Mar 2, 2021
fauxpark
fauxpark approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#pragma weak

@drashna drashna requested a review from a team March 2, 2021 16:45
@IsaacElenbaas IsaacElenbaas mentioned this pull request Mar 12, 2021
Merged
14 tasks
@tzarc tzarc merged commit 57475ca into qmk:master Mar 25, 2021
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Mar 28, 2021
@drashna @mrlinuxfish
Fix issues when manually shifting characters and Auto Shift (qmk#12083)
5928e9c 
Specifically, when using the Auto-Shift feature, if you hold and roll shift, it would not actually shift the character that you hit after the shift
@drashna drashna deleted the fix/auto_shift_shift branch April 12, 2021 06:32
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@drashna @mrtnee
Fix issues when manually shifting characters and Auto Shift (qmk#12083)
b68dec8 
Specifically, when using the Auto-Shift feature, if you hold and roll shift, it would not actually shift the character that you hit after the shift
@sigprof sigprof mentioned this pull request May 18, 2023
Open
2 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Fix issues when manually shifting characters and Auto Shift (qmk#12083)
e1bbfcd 
Specifically, when using the Auto-Shift feature, if you hold and roll shift, it would not actually shift the character that you hit after the shift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drashna @tzarc @fauxpark