Add check for non-assignment code in rules.mk #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erovia
approved these changes
May 9, 2021
|
So is this waiting for #8422 before merge? Preventing non-assignment options without a workable alternative implementation won't fly. |
|
Yes, we actually need the post processing file before this can be merged. |
13 tasks
skullydazed
force-pushed
the
rules_lint
branch
from
5ebcd7a
to
a03a66c
Compare
tzarc
approved these changes
Aug 29, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Sep 2, 2021
* qmk/develop: Remove bin/qmk (qmk#14231) ensure that the directory for sys.executable is in the user's path (qmk#14229) move everything from qmkfm/base_container to qmkfm/qmk_cli (qmk#14230) Nyquist (qmk#14202) Update the nix-shell environment (qmk#13316) [Keyboard] Add Viktus SP Mini (qmk#14069) [Keyboard] Corrected layout for np24 by YMDK (qmk#14096) [Keymap] My Prime E keymap (qmk#14117) [Keyboard] Add kelownaRGB64 (qmk#14141) [Keyboard] fix compile error `make helix/rev2/sc:all` (qmk#14214) fix automatic directory for qmk lint (qmk#14215) Add check for non-assignment code in rules.mk (qmk#12108) remove qmk console, which is now part of the global cli (qmk#14206) Fixup upstream paths for submodules. (qmk#14205) Bootmagic lite docs clarity. (qmk#14204) add 'include keyboard_features.mk' into build_keyboard.mk (qmk#8422) 2021Q3 pre-merge `develop` changelog, keyboard aliases (qmk#14198)
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
* Add check for non-assignment code in rules.mk * fix lint check * fix lint * fixup to reflect the final state of qmk#8422 * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of what we discussed in #8422 this adds a check for keyboard level
rules.mkfiles to ensure that only assignment rules are present. We can change the name to whatever we decide on in.Types of Changes
Checklist