add support for m65 and simple 5x13 ortholinear #12315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprof
reviewed
Mar 29, 2021
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
drashna
requested changes
Apr 3, 2021
drashna
approved these changes
Apr 19, 2021
fauxpark
requested changes
Apr 19, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
requested changes
Apr 19, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
|
I think that including the GD32F303CCT6 support is a bit premature — it's really a quick hack in its current state, and at least the EEPROM emulation support needs some further work at the moment. It should probably be better to get the tested rev1 merged first, then rev2 could be added later. |
zvecr
requested changes
May 3, 2021
Co-authored-by: Joel Challis <git@zvecr.com>
fauxpark
requested changes
May 4, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
|
Could you revert the changes to the git submodules (lib folders)? you may need to rebase your branch to properly fix this. |
done, thank you! |
drashna
approved these changes
May 22, 2021
|
Thank you for your contribution! |
noroadsleft
requested changes
Aug 10, 2021
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft
approved these changes
Aug 10, 2021
tzarc
approved these changes
Aug 10, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* add support for m65 and simple 5x13 ortholinear * Update keyboards/m65/keymaps/default/keymap.c Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * Update keyboards/m65/keymaps/default/keymap.c Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * Update keyboards/m65/keymaps/default/keymap.c Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * Update keyboards/m65/keymaps/default/keymap.c Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * Update keyboards/m65/keymaps/default/keymap.c Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * Update keyboards/m65/keymaps/default/keymap.c Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * updates as per @sigprof review plus reformat * pins all now are defined at microcontroller level * profuct id defined at microcontroller level * put leds on when _ADJ is on * add danish keymap * make default uk centric iso as per readme * default is now iso generic, uk is its own business * add license * update imgur links to reflect the layout * leds for _ADJ layer now do not prevent the other layers leds to get on * Update keyboards/m65/keymaps/uk/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/m65/keymaps/dk/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/m65/keymaps/uk/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/m65/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * add support for gd32f303cct6 by we act in rev2 * Revert "add support for gd32f303cct6 by we act in rev2" This reverts commit 4ad3834. * Update keyboards/m65/rev1/rules.mk Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/m65/keymaps/dk/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/m65/keymaps/uk/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/m65/keymaps/default/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * remove empty hal * add capslock * Update keyboards/m65/readme.md Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/m65/config.h Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Alin M Elena <alin-marin.elena@stfc.ac.uk> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
all the comments are in here this pr #12012 superseeds #12012
Types of Changes
Issues Fixed or Closed by This PR
Checklist