[Keyboard] Update Symmetric70 keyboard prototype #12707

mtei · 2021-04-26T20:32:40Z

Description

The following additions have been made to the Symmetric70 keyboard prototype.

Added a version using Proton C.

Added adaptive delay code.

MCU	matrix.c	delay type	execution time of `matrix_scan()`	matrix scan rate
Pro Micro (16MHz)	normal	default	503us	1810 scans/sec
Pro Micro (16MHz)	normal	adaptive	383us	2320 scans/sec
Pro Micro (16MHz)	normal	fast adaptive	382us	2330 scans/sec
Proton C (72MHz)	normal	default	210us	4350 scans/sec
Proton C (72MHz)	normal	adaptive	76.4us	10600 scans/sec
Proton C (72MHz)	normal	fast adaptive	75.6us	10800 scans/sec

see more detail "normal matrix", "adaptive delay", "fast adaptive delay"

Added fast and extensible matrix.c.

MCU	matrix.c	delay type	execution time of `matrix_scan()`	matrix scan rate
Pro Micro (16MHz)	fast	fast adaptive	75.6us	8090 scans/sec
Proton C (72MHz)	fast	fast adaptive	49.8us	15100 scans/sec

see more detail "fast matrix"

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…features.mk etc. set MATRIX_IO_DELAY macro make MTEST=mdelay0 symmetric70_proto/promicro:default:flash make MTEST=mdelay1 symmetric70_proto/promicro:default:flash make MTEST=mdelay10 symmetric70_proto/promicro:default:flash make MTEST=mdelay30 symmetric70_proto/promicro:default:flash set DEBUG_MATRIX_SCAN_RATE_ENABLE yes make MTEST=scan symmetric70_proto/promicro:default:flash set MATRIX_DEBUG_DELAY and MATRIX_IO_DELAY macro make MTEST=matrix_debug_delay,mdelay0 symmetric70_proto/promicro:default:flash set MATRIX_DEBUG_SCAN make MTEST=matrix_debug_scan symmetric70_proto/promicro:default:flash

support MATRIX_IO_DELAY_DEFAULT for testing.

stale · 2021-07-10T20:08:26Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboards/handwired/symmetric70_proto/proton_c/rules.mk

tzarc

Fair few source files are also missing copyright headers, should add those too.

keyboards/handwired/symmetric70_proto/local_features.mk

keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c

keyboards/handwired/symmetric70_proto/matrix_debug/readme.md

keyboards/handwired/symmetric70_proto/matrix_fast/matrix_config_expand.c

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Nick Brassel <nick@tzarc.org>

…g_expand.c Co-authored-by: Nick Brassel <nick@tzarc.org>

* update handwired/symmetric70_proto/matrix.c * make keyboards/handwired/symmetric70_proto/promicro/ * add symmetric70_proto/debug_config.h, update symmetric70_proto/local_features.mk etc. set MATRIX_IO_DELAY macro make MTEST=mdelay0 symmetric70_proto/promicro:default:flash make MTEST=mdelay1 symmetric70_proto/promicro:default:flash make MTEST=mdelay10 symmetric70_proto/promicro:default:flash make MTEST=mdelay30 symmetric70_proto/promicro:default:flash set DEBUG_MATRIX_SCAN_RATE_ENABLE yes make MTEST=scan symmetric70_proto/promicro:default:flash set MATRIX_DEBUG_DELAY and MATRIX_IO_DELAY macro make MTEST=matrix_debug_delay,mdelay0 symmetric70_proto/promicro:default:flash set MATRIX_DEBUG_SCAN make MTEST=matrix_debug_scan symmetric70_proto/promicro:default:flash * add symmetric70_proto/matrix_debug/readme.md * update symmetric70_proto/matrix_debug/readme.md * update handwired/symmetric70_proto/readme.md * update handwired/symmetric70_proto/readme.md * update handwired/symmetric70_proto/*/readme.md * add handwired/symmetric70_proto/matrix_fast/ * update handwired/symmetric70_proto/matrix_fast/readme.md * fix typo in handwired/symmetric70_proto/matrix_fast/readme.md * update config.h under handwired/symmetric70_proto/promicro * add Proton C support to handwired/symmetric70_proto * add handwired/symmetric70_proto/proton_c/readme.md * add promicro/*/readme.md proton_c/*/readme.md * update handwired/symmetric70_proto/proton_c/proton_c.c support MATRIX_IO_DELAY_DEFAULT for testing. * Added another implementation of 'adaptive_delay'. * update symmetric70_proto/local_features.mk * update symmetric70_proto/matrix_fast/gpio_extr.h * add matrix_output_unselect_delay_ports() * add MTEST=adaptive_delay_fast option * update symmetric70_proto/matrix_debug/readme.md * update symmetric70_proto/matrix_fast/readme.md * update symmetric70_proto/matrix_debug/readme.md * Erase garbage * fix symmetric70_proto/proton_c/proton_c.c * improve adaptive_delay_fast in symmetric70_proto/matrix_debug/matrix.c * update symmetric70_proto/matrix_debug/readme.md * fix symmetric70_proto/matrix_debug/readme.md * Update keyboards/handwired/symmetric70_proto/proton_c/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/handwired/symmetric70_proto/proton_c/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/handwired/symmetric70_proto/local_features.mk Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/local_features.mk Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/local_features.mk Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_debug/readme.md Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_debug/readme.md Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_debug/readme.md Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keyboards/handwired/symmetric70_proto/matrix_fast/matrix_config_expand.c Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Nick Brassel <nick@tzarc.org>

mtei added 14 commits April 18, 2021 11:29

update handwired/symmetric70_proto/matrix.c

5af732b

make keyboards/handwired/symmetric70_proto/promicro/

33e9ad5

add symmetric70_proto/matrix_debug/readme.md

ba71309

update symmetric70_proto/matrix_debug/readme.md

6094a76

update handwired/symmetric70_proto/readme.md

64db8a6

update handwired/symmetric70_proto/readme.md

3491fbb

update handwired/symmetric70_proto/*/readme.md

4188fbb

add handwired/symmetric70_proto/matrix_fast/

b8e7eaa

update handwired/symmetric70_proto/matrix_fast/readme.md

77a05c4

fix typo in handwired/symmetric70_proto/matrix_fast/readme.md

6da7303

update config.h under handwired/symmetric70_proto/promicro

71f9514

add Proton C support to handwired/symmetric70_proto

5196d7d

add handwired/symmetric70_proto/proton_c/readme.md

7b5c480

github-actions bot added the keyboard label Apr 26, 2021

mtei added 7 commits April 27, 2021 20:35

add promicro/*/readme.md proton_c/*/readme.md

7cf19d5

update handwired/symmetric70_proto/proton_c/proton_c.c

a75273f

support MATRIX_IO_DELAY_DEFAULT for testing.

Added another implementation of 'adaptive_delay'.

2c17f7a

update symmetric70_proto/local_features.mk

8d29afa

update symmetric70_proto/matrix_fast/gpio_extr.h

a2f1e3c

add matrix_output_unselect_delay_ports()

c71b62a

add MTEST=adaptive_delay_fast option

369a2d6

drashna requested a review from a team May 22, 2021 05:21

mtei added 3 commits May 23, 2021 01:55

update symmetric70_proto/matrix_debug/readme.md

1f2d00e

update symmetric70_proto/matrix_fast/readme.md

840cfb5

update symmetric70_proto/matrix_debug/readme.md

2a0e91f

mtei mentioned this pull request May 22, 2021

matrix: wait for row signal to go HIGH for every row #12945

Merged

14 tasks

mtei added 3 commits May 23, 2021 08:02

Erase garbage

6a2337d

fix symmetric70_proto/proton_c/proton_c.c

af4a197

improve adaptive_delay_fast in symmetric70_proto/matrix_debug/matrix.c

aea6741

mtei added 2 commits May 26, 2021 23:05

update symmetric70_proto/matrix_debug/readme.md

7a4ee9e

fix symmetric70_proto/matrix_debug/readme.md

b8dc9bd

stale bot added the awaiting changes label Jul 10, 2021

fauxpark requested changes Jul 13, 2021

View reviewed changes

keyboards/handwired/symmetric70_proto/proton_c/rules.mk Outdated Show resolved Hide resolved

keyboards/handwired/symmetric70_proto/proton_c/rules.mk Show resolved Hide resolved

stale bot removed the awaiting changes label Jul 13, 2021

tzarc requested changes Jul 13, 2021

View reviewed changes

mtei and others added 12 commits July 13, 2021 17:48

Update keyboards/handwired/symmetric70_proto/proton_c/rules.mk

ea2d154

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/handwired/symmetric70_proto/proton_c/rules.mk

4548510

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/handwired/symmetric70_proto/local_features.mk

49d67c1

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/local_features.mk

cbb9107

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c

4ec4398

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c

d2439ff

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/local_features.mk

55a03ae

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_debug/matrix.c

8185032

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_debug/readme.md

bf8be27

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_debug/readme.md

7452d40

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_debug/readme.md

6cfa016

Co-authored-by: Nick Brassel <nick@tzarc.org>

Update keyboards/handwired/symmetric70_proto/matrix_fast/matrix_confi…

cf1d8c1

…g_expand.c Co-authored-by: Nick Brassel <nick@tzarc.org>

tzarc approved these changes Jul 13, 2021

View reviewed changes

mtei merged commit b89abc4 into qmk:master Jul 13, 2021

mtei deleted the update_symmetric70_proto branch July 13, 2021 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Update Symmetric70 keyboard prototype #12707

[Keyboard] Update Symmetric70 keyboard prototype #12707

mtei commented Apr 26, 2021 •

edited

stale bot commented Jul 10, 2021

tzarc left a comment

[Keyboard] Update Symmetric70 keyboard prototype #12707

[Keyboard] Update Symmetric70 keyboard prototype #12707

Conversation

mtei commented Apr 26, 2021 • edited

Description

Types of Changes

Checklist

stale bot commented Jul 10, 2021

tzarc left a comment

Choose a reason for hiding this comment

mtei commented Apr 26, 2021 •

edited