Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pass at data driven new-keyboard subcommand #12795

Merged
merged 4 commits into from Feb 8, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 3, 2021

Description

Builds on previous iterations by leaning on the community defaults and json schemas.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels May 3, 2021
@stale

This comment has been minimized.

@zvecr zvecr mentioned this pull request Jul 25, 2021
14 tasks
@zvecr zvecr force-pushed the feature/new_keyboard2 branch 2 times, most recently from ab04947 to f2fe96d Compare July 25, 2021 13:51
@zvecr zvecr changed the title Initial pass at new keyboard subcommand Initial pass at data driven new-keyboard subcommand Oct 9, 2021
@zvecr zvecr force-pushed the feature/new_keyboard2 branch 2 times, most recently from c6a9489 to bbac107 Compare November 4, 2021 19:34
@zvecr zvecr marked this pull request as ready for review November 4, 2021 21:10
@zvecr zvecr requested a review from a team November 4, 2021 21:44
@drashna
Copy link
Member

drashna commented Jan 4, 2022

"none of the above" doesn't work.

<class 'FileNotFoundError'>
☒ [Errno 2] No such file or directory: 'layouts/default/none of the above/default_none of the above'
Traceback (most recent call last):
  File "/usr/local/Cellar/qmk/1.0.0_1/libexec/lib/python3.9/site-packages/milc/milc.py", line 526, in __call__
    return self.__call__()
  File "/usr/local/Cellar/qmk/1.0.0_1/libexec/lib/python3.9/site-packages/milc/milc.py", line 531, in __call__
    return self._subcommand(self)
  File "/Users/drashna/repos/qmk_firmware/lib/python/qmk/cli/new/keyboard.py", line 187, in new_keyboard
    shutil.copytree(community_keymap, keymaps_path / 'default')
  File "/usr/local/Cellar/python@3.9/3.9.9/Frameworks/Python.framework/Versions/3.9/lib/python3.9/shutil.py", line 564, in copytree
    with os.scandir(src) as itr:
FileNotFoundError: [Errno 2] No such file or directory: 'layouts/default/none of the above/default_none of the above'

@zvecr zvecr changed the base branch from master to develop February 4, 2022 21:44
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support cli qmk cli command and removed cli qmk cli command via Adds via keymap and/or updates keyboard for via support keymap keyboard labels Feb 4, 2022
@zvecr
Copy link
Member Author

zvecr commented Feb 4, 2022

"none of the above" doesn't work.

Should now be resolved in the short term

tzarc
tzarc previously approved these changes Feb 8, 2022
@tzarc tzarc requested a review from a team February 8, 2022 17:50
@tzarc tzarc dismissed their stale review February 8, 2022 17:57

Need a bootloader, now.

@tzarc tzarc merged commit 2e279f1 into qmk:develop Feb 8, 2022
Erovia added a commit to Erovia/qmk_firmware that referenced this pull request Feb 8, 2022
Make the output a little bit easier to read and provide more context to
the user when the selected keyboard name is already used.
@Erovia Erovia mentioned this pull request Feb 8, 2022
14 tasks
Erovia added a commit that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert new_keyboard.sh to a python command
3 participants