Adding bm60ec rgb #12852

umbacos · 2021-05-09T21:35:02Z

Hi, I wrote the keyboard "bm60ec rgb" which is the bm60 with rotary encoder that was missing in the QMK master branch.

Description

created a new directory under keyboard called bm60ec_rgb, and added all the required files, including via support

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna · 2021-05-10T06:23:42Z

Please revert all changes outside of the keyboard addition, itself.

drashna

You have a lot of additions changes outside of the bm60ec rgb keyboard.

Please revert these changes. If you need help with this, don't hesitate to ask.

.gitignore

drashna · 2021-08-13T19:39:18Z

keyboards/40percentclub/gherkin/keymaps/umbacos/config.h

@@ -0,0 +1,23 @@
+#pragma once


Could you add a GPL2+ compatible license header here?

For instance:

qmk_firmware/quantum/template/base/keyboard.c

Lines 1 to 15 in 28ff511

/* Copyright %YEAR% %YOUR_NAME%

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 2 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

drashna · 2021-08-13T19:39:28Z

keyboards/40percentclub/gherkin/keymaps/umbacos/config.h

+
+#define RGB_DI_PIN D3
+#define RGBLED_NUM 20
+#define RGBLIGHT_ANIMATIONS


Could you explicitly define which animations are enabled?

Suggested change

#define RGBLIGHT_ANIMATIONS

#define RGBLIGHT_EFFECT_BREATHING

#define RGBLIGHT_EFFECT_RAINBOW_MOOD

#define RGBLIGHT_EFFECT_RAINBOW_SWIRL

#define RGBLIGHT_EFFECT_SNAKE

#define RGBLIGHT_EFFECT_KNIGHT

#define RGBLIGHT_EFFECT_CHRISTMAS

#define RGBLIGHT_EFFECT_STATIC_GRADIENT

#define RGBLIGHT_EFFECT_RGB_TEST

#define RGBLIGHT_EFFECT_ALTERNATING

#define RGBLIGHT_EFFECT_TWINKLE

drashna · 2021-08-13T19:39:39Z

keyboards/40percentclub/gherkin/keymaps/umbacos/keymap.c

@@ -0,0 +1,252 @@
+#include QMK_KEYBOARD_H


Could you add a GPL2+ compatible license header here?

For instance:

qmk_firmware/quantum/template/base/keyboard.c

Lines 1 to 15 in 28ff511

/* Copyright %YEAR% %YOUR_NAME%

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 2 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

drashna · 2021-08-13T19:39:51Z

keyboards/40percentclub/gherkin/keymaps/umbacos/keymap.c

+#ifdef AUDIO_ENABLE
+  #include "audio.h"
+#endif


Suggested change

#ifdef AUDIO_ENABLE

#include "audio.h"

#endif

drashna · 2021-08-13T19:39:58Z

keyboards/40percentclub/gherkin/keymaps/umbacos/keymap.c

+  #include "audio.h"
+#endif
+
+extern keymap_config_t keymap_config;


Suggested change

extern keymap_config_t keymap_config;

drashna · 2021-08-13T19:40:33Z

keyboards/40percentclub/gherkin/keymaps/umbacos_light/config.h

@@ -0,0 +1,25 @@
+#pragma once


Could you add a GPL2+ compatible license header here?

For instance:

qmk_firmware/quantum/template/base/keyboard.c

Lines 1 to 15 in 28ff511

/* Copyright %YEAR% %YOUR_NAME%

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 2 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

drashna · 2021-08-13T19:40:52Z

keyboards/40percentclub/gherkin/keymaps/umbacos_light/config.h

+
+#define RGB_DI_PIN F6
+#define RGBLED_NUM 6
+#define RGBLIGHT_ANIMATIONS


Could you explicitly define which animations are enabled?

Suggested change

#define RGBLIGHT_ANIMATIONS

#define RGBLIGHT_EFFECT_BREATHING

#define RGBLIGHT_EFFECT_RAINBOW_MOOD

#define RGBLIGHT_EFFECT_RAINBOW_SWIRL

#define RGBLIGHT_EFFECT_SNAKE

#define RGBLIGHT_EFFECT_KNIGHT

#define RGBLIGHT_EFFECT_CHRISTMAS

#define RGBLIGHT_EFFECT_STATIC_GRADIENT

#define RGBLIGHT_EFFECT_RGB_TEST

#define RGBLIGHT_EFFECT_ALTERNATING

#define RGBLIGHT_EFFECT_TWINKLE

drashna · 2021-08-13T19:41:02Z

keyboards/40percentclub/gherkin/keymaps/umbacos_light/keymap.c

@@ -0,0 +1,80 @@
+#include QMK_KEYBOARD_H


Could you add a GPL2+ compatible license header here?

For instance:

qmk_firmware/quantum/template/base/keyboard.c

Lines 1 to 15 in 28ff511

/* Copyright %YEAR% %YOUR_NAME%

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 2 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

drashna · 2021-08-13T19:41:10Z

keyboards/40percentclub/gherkin/keymaps/umbacos_midi/config.h

@@ -0,0 +1,17 @@
+#pragma once


Could you add a GPL2+ compatible license header here?

For instance:

qmk_firmware/quantum/template/base/keyboard.c

Lines 1 to 15 in 28ff511

/* Copyright %YEAR% %YOUR_NAME%

*

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 2 of the License, or

* (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

*

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

*/

filterpaper · 2021-09-15T12:03:15Z

KPrepublic PCBs are now located within keyboards/kprepublic. bm60ec_rgb should reside in there as well.

peepeetee · 2021-11-06T12:34:28Z

Also, I standardized the naming format for KPrepublic PCBs. (see #15047) See if you can rename the board to bm60ec

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: takashicompany <takashicompany@TMPB2021.local>

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>

acting in lieu of bdtc123 Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>

stale · 2022-04-17T08:33:38Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

stale · 2022-06-12T15:55:18Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

github-actions bot added core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 9, 2021

github-actions bot added the dependencies label May 12, 2021

drashna requested changes Jun 16, 2021

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

github-actions bot removed the core label Jul 14, 2021

drashna requested changes Aug 13, 2021

View reviewed changes

peepeetee mentioned this pull request Nov 7, 2021

rename kprepublic bm keyboards to have a standardized naming format #15047

Merged

14 tasks

umbacos added 18 commits December 10, 2021 16:42

initial checkin

741a199

initial commit

83b8a4c

added makefiles

3baedf9

sa

ac2aba1

refresh

ecf327d

Create mail

a477049

Delete mail

91533ea

spi

8bd3d4c

bm43a updated

652816b

added rama m65

c0e46d2

update m65b

d80994f

added bm60ec rgb

4895b8e

changed name to the directory

9c4f42b

fixed directories

28f9664

added readme.md

d64e915

rebaselined qmk

2aa3a87

dz60

391e36a

okok

bb439e4

umbacos and others added 18 commits December 10, 2021 16:52

ok

b6c0393

fixed encoders

06bb570

ok

9369df0

ok

71d8483

ok

9e34daa

update

1f4c306

ok

a03aea3

win_mac

0d4413d

abba

8cd49f9

new keymap

4694eae

[Keyboard] Add Waka60 keyboard (#15173)

0dc2bdb

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>

[Keyboard] add Radialex (#14949)

fb93869

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: takashicompany <takashicompany@TMPB2021.local>

[Keyboard] Add ginkgo65hot (#15404)

0aa59ee

Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>

[Keyboard] Add KPrepublic BM60hsrgb/rev2 (#15177)

9294258

acting in lieu of bdtc123 Co-authored-by: Ryan <fauxpark@gmail.com>

bugfix (I don't know what's changed yet but something changed) (#15455)

711a608

[Keyboard] Add XS60 (#15248)

ae34dde

Co-authored-by: Ryan <fauxpark@gmail.com>

a

d566c7c

Merge branch 'master' of https://github.com/umbacos/qmk_firmware

67920f6

stale bot added the awaiting changes label Apr 17, 2022

stale bot closed this Jun 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding bm60ec rgb #12852

Adding bm60ec rgb #12852

umbacos commented May 9, 2021

drashna commented May 10, 2021

drashna left a comment

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

drashna Aug 13, 2021

filterpaper commented Sep 15, 2021

peepeetee commented Nov 6, 2021

stale bot commented Apr 17, 2022

stale bot commented Jun 12, 2022

	/* Copyright %YEAR% %YOUR_NAME%
	*
	* This program is free software: you can redistribute it and/or modify
	* it under the terms of the GNU General Public License as published by
	* the Free Software Foundation, either version 2 of the License, or
	* (at your option) any later version.
	*
	* This program is distributed in the hope that it will be useful,
	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	* GNU General Public License for more details.
	*
	* You should have received a copy of the GNU General Public License
	* along with this program. If not, see <http://www.gnu.org/licenses/>.
	*/

-#define RGBLIGHT_ANIMATIONS
+#define RGBLIGHT_EFFECT_BREATHING
+#define RGBLIGHT_EFFECT_RAINBOW_MOOD
+#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
+#define RGBLIGHT_EFFECT_SNAKE
+#define RGBLIGHT_EFFECT_KNIGHT
+#define RGBLIGHT_EFFECT_CHRISTMAS
+#define RGBLIGHT_EFFECT_STATIC_GRADIENT
+#define RGBLIGHT_EFFECT_RGB_TEST
+#define RGBLIGHT_EFFECT_ALTERNATING
+#define RGBLIGHT_EFFECT_TWINKLE

Adding bm60ec rgb #12852

Adding bm60ec rgb #12852

Conversation

umbacos commented May 9, 2021

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

drashna commented May 10, 2021

drashna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

filterpaper commented Sep 15, 2021

peepeetee commented Nov 6, 2021

stale bot commented Apr 17, 2022

stale bot commented Jun 12, 2022