Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix: wait for row signal to go HIGH for every row #12945

Merged
merged 1 commit into from
May 19, 2021
Merged

matrix: wait for row signal to go HIGH for every row #12945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions quantum/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ static bool read_cols_on_row(matrix_row_t current_matrix[], uint8_t current_row)

// Unselect row
unselect_row(current_row);
if (current_row + 1 < MATRIX_ROWS) {
matrix_output_unselect_delay(); // wait for row signal to go HIGH
}
matrix_output_unselect_delay(); // wait for all Col signals to go HIGH

// If the row has changed, store the row and return the changed flag.
if (current_matrix[current_row] != current_row_value) {
Expand Down Expand Up @@ -178,9 +176,7 @@ static bool read_rows_on_col(matrix_row_t current_matrix[], uint8_t current_col)

// Unselect col
unselect_col(current_col);
if (current_col + 1 < MATRIX_COLS) {
matrix_output_unselect_delay(); // wait for col signal to go HIGH
}
matrix_output_unselect_delay(); // wait for all Row signals to go HIGH

return matrix_changed;
}
Expand Down
8 changes: 2 additions & 6 deletions quantum/split_common/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,7 @@ static bool read_cols_on_row(matrix_row_t current_matrix[], uint8_t current_row)

// Unselect row
unselect_row(current_row);
if (current_row + 1 < MATRIX_ROWS) {
matrix_output_unselect_delay(); // wait for row signal to go HIGH
}
matrix_output_unselect_delay(); // wait for all Col signals to go HIGH

// If the row has changed, store the row and return the changed flag.
if (current_matrix[current_row] != current_row_value) {
Expand Down Expand Up @@ -192,9 +190,7 @@ static bool read_rows_on_col(matrix_row_t current_matrix[], uint8_t current_col)

// Unselect col
unselect_col(current_col);
if (current_col + 1 < MATRIX_COLS) {
matrix_output_unselect_delay(); // wait for col signal to go HIGH
}
matrix_output_unselect_delay(); // wait for all Row signals to go HIGH

return matrix_changed;
}
Expand Down