Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use milc.subcommand.config instead of qmk.cli.config #13002

Merged
merged 1 commit into from
May 25, 2021
Merged

Use milc.subcommand.config instead of qmk.cli.config #13002

merged 1 commit into from
May 25, 2021

Conversation

skullydazed
Copy link
Member

Description

Pull #12915 into master ahead of the develop merge, to fix config not being set.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed
Use milc.subcommand.config instead of qmk.cli.config
d3754c0 
* Use milc.subcommand.config instead

* pyformat

* remove the config test
@skullydazed skullydazed requested a review from a team May 25, 2021 06:31
@github-actions github-actions bot added cli qmk cli command python labels May 25, 2021
@skullydazed skullydazed merged commit aa97f52 into master May 25, 2021
@skullydazed skullydazed deleted the use_milc_config branch May 25, 2021 06:36
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@skullydazed @HokieGeek
Use milc.subcommand.config instead of qmk.cli.config (qmk#13002)
7371007 
* Use milc.subcommand.config instead

* pyformat

* remove the config test
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@skullydazed @nhongooi
Use milc.subcommand.config instead of qmk.cli.config (qmk#13002)
1970d74 
* Use milc.subcommand.config instead

* pyformat

* remove the config test
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Use milc.subcommand.config instead of qmk.cli.config (qmk#13002)
25a5abc 
* Use milc.subcommand.config instead

* pyformat

* remove the config test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skullydazed @fauxpark