Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: bump USB spec version in device descriptor to 2.0 #13078

Merged
merged 3 commits into from
Jun 6, 2021
Merged

core: bump USB spec version in device descriptor to 2.0 #13078

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65a36d4
core: allow setting USB version in descriptor to USB 2 from config.h
stapelberg Apr 5, 2021
99d8f73
Set USB version to 2, 0, 0 unconditionally
stapelberg Jun 5, 2021
a7c67f7
Remove doc update from docs/config_options.md
stapelberg Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/config_options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ This is a C header file that is one of the first things included, and will persi
* sets the USB polling rate in milliseconds for the keyboard, mouse, and shared (NKRO/media keys) interfaces
* `#define USB_SUSPEND_WAKEUP_DELAY 200`
* set the number of milliseconde to pause after sending a wakeup packet
* `#define USB_VERSION_2`
* set the USB device descriptor to USB version 2.
stapelberg marked this conversation as resolved.
Show resolved Hide resolved
* `#define F_SCL 100000L`
* sets the I2C clock rate speed for keyboards using I2C. The default is `400000L`, except for keyboards using `split_common`, where the default is `100000L`.

Expand Down
4 changes: 4 additions & 0 deletions tmk_core/protocol/usb_descriptor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,11 @@ const USB_Descriptor_Device_t PROGMEM DeviceDescriptor = {
.Size = sizeof(USB_Descriptor_Device_t),
.Type = DTYPE_Device
},
#if defined(USB_VERSION_2)
.USBSpecification = VERSION_BCD(2, 0, 0),
#else
.USBSpecification = VERSION_BCD(1, 1, 0),
#endif
stapelberg marked this conversation as resolved.
Show resolved Hide resolved

#if VIRTSER_ENABLE
.Class = USB_CSCP_IADDeviceClass,
Expand Down