Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor atom47 and add rev4 and rev5 #13201

Merged
merged 8 commits into from Aug 19, 2021
Merged

Refactor atom47 and add rev4 and rev5 #13201

merged 8 commits into from Aug 19, 2021

Conversation

evyd13
Copy link
Contributor

@evyd13 evyd13 commented Jun 13, 2021 •
edited

Description

Refactors the atom47, adds rev4 and rev5. Rev4 is a very minimalistic version and rev5 is the opposite.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 13, 2021
@evyd13
Copy link
Contributor Author

evyd13 commented Jun 14, 2021

This is a breaking change, by the way.

@drashna
Copy link
Member

drashna commented Aug 12, 2021

There are merge conflicts here.

@evyd13
Copy link
Contributor Author

evyd13 commented Aug 12, 2021

Should be solved now!

@drashna drashna requested a review from a team August 12, 2021 15:49
fauxpark
fauxpark requested changes Aug 12, 2021
View reviewed changes
keyboards/evyd13/atom47/readme.md Outdated Show resolved Hide resolved
keyboards/evyd13/atom47/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/evyd13/atom47/rev4/rev4.c Outdated Show resolved Hide resolved
keyboards/evyd13/atom47/rev4/rules.mk Outdated Show resolved Hide resolved
keyboards/evyd13/atom47/rev5/rev5.c Outdated Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Aug 17, 2021

@evyd13 I've pushed some changes that should fix things once merged, can you pull your branch and give them a quick try-out?

@evyd13
Copy link
Contributor Author

evyd13 commented Aug 18, 2021

@tzarc I'm getting the following error on building the rev5 with any keymap: https://pastebin.com/gRFDT2eN

@fauxpark
Copy link
Member

You need to be on the develop branch.

@evyd13
Copy link
Contributor Author

evyd13 commented Aug 18, 2021

You need to be on the develop branch.

Ah, works perfectly now :)

@drashna drashna merged commit 81e19d6 into qmk:develop Aug 19, 2021
@evyd13 evyd13 mentioned this pull request Nov 5, 2021
Closed
13 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@evyd13 @tzarc @nhongooi
[Keyboard] Refactor atom47 and add rev4 and rev5 (qmk#13201)
6ebb0ba 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evyd13 @drashna @tzarc @fauxpark