Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encoder mapping. #13286

Merged
merged 4 commits into from Mar 9, 2022
Merged

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jun 21, 2021

Description

Proof-of-concept: adds encoder mapping, much like electrical matrix mapping.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 21, 2021
@tzarc
Copy link
Member Author

tzarc commented Jun 21, 2021

For discussion RE: #12982 -- intention is to spur discussion about direction.

@tzarc tzarc force-pushed the feature/generic_input_events branch 3 times, most recently from d0932a3 to eb1751c Compare June 21, 2021 21:22
@github-actions github-actions bot removed keyboard via Adds via keymap and/or updates keyboard for via support keymap labels Jun 21, 2021
@tzarc tzarc force-pushed the feature/generic_input_events branch from eb1751c to 1aeb59d Compare June 21, 2021 21:33
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 21, 2021
@tzarc tzarc changed the title WIP: Add support for encoder mapping. Add support for encoder mapping. Jun 21, 2021
@tzarc tzarc marked this pull request as ready for review June 21, 2021 22:05
@tzarc tzarc requested a review from a team June 21, 2021 22:05
@tzarc tzarc force-pushed the feature/generic_input_events branch from 1aeb59d to 3e2cc1b Compare June 21, 2021 22:06
@github-actions github-actions bot added documentation and removed keymap via Adds via keymap and/or updates keyboard for via support keyboard labels Jun 21, 2021
@tzarc tzarc force-pushed the feature/generic_input_events branch from 0890056 to 12b21a8 Compare June 21, 2021 22:53
@drashna
Copy link
Member

drashna commented Jun 22, 2021

Can confirm that this works, and on both sides of a split.

This works, but it creates some really, really weird behavior with encoder mapping enabled. On both my oled, and mouse layer stuff (it triggers the "lock mouse on" behavior, though it shouldn't be calling the code AT ALL, and it prints gibberish to the OLED when it ... shouldn't be able to).

Disabling the encoder mapping fixes the issue immediately...

I can no longer reproduce this behavior...

However, it doesn't handle default layers well. It doesn't "fall through" properly.

In fact, it behaves like it's using the keymap, and not the encoder map

@tzarc tzarc force-pushed the feature/generic_input_events branch from b567658 to 8e55cbd Compare June 27, 2021 22:57
@drashna
Copy link
Member

drashna commented Jul 4, 2021

Can confirm, on missing layers (eg when using default layers), it's using the keymap instead of the encoder map.

@tzarc tzarc force-pushed the feature/generic_input_events branch 2 times, most recently from 1739a34 to 3e6a5f2 Compare July 10, 2021 01:06
@tzarc tzarc moved this from In progress to Review in progress in XAP MVP (OLD, check migrated projects) Mar 8, 2022
@github-actions github-actions bot added cli qmk cli command python labels Mar 8, 2022
@tzarc tzarc force-pushed the feature/generic_input_events branch 2 times, most recently from 40f0265 to 8f07c49 Compare March 9, 2022 07:31
@tzarc tzarc force-pushed the feature/generic_input_events branch from 8f07c49 to ee3df11 Compare March 9, 2022 07:31
@tzarc tzarc merged commit 8d5eacb into qmk:develop Mar 9, 2022
XAP MVP (OLD, check migrated projects) automation moved this from Review in progress to Done Mar 9, 2022
@tzarc tzarc deleted the feature/generic_input_events branch March 9, 2022 08:29
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Mar 23, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment cli qmk cli command core documentation keyboard python xap XAP-related issues/PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants